Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust determination of rtype location / fix issue 302 #304

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

hoodmane
Copy link
Collaborator

Resolves #302.

This increases the robustness of the handling of the docutils tree. The docutils rst parser seems to have a bunch of bugs / shortcomings. The original problem was that several list types do not get their line number set. So to find the line number of a node, if the node itself has None as the line number, we descend through the first children of the node until we find one with a non-None line number.

Resolves 302.

This increases the robustness of the handling of the docutils tree.
The docutils rst parser seems to have a bunch of bugs / shortcomings.
The original problem was that several list types do not get their line
number set. So to find the line number of a node, if the node itself has
None as the line number, we descend through the first children of the
node until we find one with a non-None line number.
@gaborbernat gaborbernat merged commit 8c931fe into tox-dev:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cryptic error message from failing to parse invalid rst docstrings
2 participants